Skip to content

[UUM-136930] Fix Arch field not readable#674

Open
lopezt-unity wants to merge 6 commits into
masterfrom
bugfix/uum-136930-fix-arch-field-not-readable
Open

[UUM-136930] Fix Arch field not readable#674
lopezt-unity wants to merge 6 commits into
masterfrom
bugfix/uum-136930-fix-arch-field-not-readable

Conversation

@lopezt-unity
Copy link
Copy Markdown
Collaborator

Purpose of this PR

This PR shorten the label "Arch circumference" to "Arch circ." to avoid a cut in the Editor UIs.
This choice has been done to align with the Torus shape that is already doing this.

Links

Jira: https://jira.unity3d.com/browse/UUM-136930

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

Copy link
Copy Markdown
Contributor

@u-pr u-pr Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May require changes

The changes update shape editing capabilities but leave behind some diagnostic profiling code and modify undo/redo behavior that needs verification. A quick cleanup and review of the undo logic is recommended.

🤖 Helpful? 👍/👎

Comment thread Editor/EditorCore/ProBuilderShapeEditor.cs Outdated
Comment thread Editor/EditorCore/ProBuilderShapeEditor.cs Outdated
Comment thread Editor/EditorCore/ProBuilderShapeEditor.cs Outdated
@codecov-github-com
Copy link
Copy Markdown

codecov-github-com Bot commented Jun 1, 2026

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Editor/EditorCore/ProBuilderShapeEditor.cs 0.00% 1 Missing ⚠️
Runtime/Shapes/Arch.cs 0.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   38.01%   38.02%           
=======================================
  Files         278      278           
  Lines       38851    38859    +8     
=======================================
+ Hits        14771    14775    +4     
- Misses      24080    24084    +4     
Flag Coverage Δ
probuilder_MacOS_6000.0 35.64% <0.00%> (ø)
probuilder_MacOS_6000.3 35.64% <0.00%> (ø)
probuilder_MacOS_6000.4 35.64% <0.00%> (ø)
probuilder_MacOS_6000.5 35.64% <0.00%> (ø)
probuilder_MacOS_6000.6 35.64% <0.00%> (ø)
probuilder_Ubuntu_6000.6 ?
probuilder_Windows_6000.0 35.56% <0.00%> (ø)
probuilder_Windows_6000.3 35.56% <0.00%> (ø)
probuilder_Windows_6000.4 35.56% <0.00%> (ø)
probuilder_Windows_6000.5 35.56% <0.00%> (ø)
probuilder_Windows_6000.6 35.56% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Editor/EditorCore/ProBuilderShapeEditor.cs 6.58% <0.00%> (+1.55%) ⬆️
Runtime/Shapes/Arch.cs 62.69% <0.00%> (ø)

... and 1 file with indirect coverage changes

ℹ️ Need help interpreting these results?

Copy link
Copy Markdown
Contributor

@modrimkus-unity modrimkus-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants